Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to temporarily disable Glide hack while sneaking #919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add option to temporarily disable Glide hack while sneaking #919

wants to merge 1 commit into from

Conversation

Lamby777
Copy link

@Lamby777 Lamby777 commented Jan 3, 2024

See #368, no more formatting issues and stuff.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jan 3, 2024 •
edited
Loading

Walkthrough

Walkthrough

The GlideHack feature in a Java application has been updated to introduce a new option that allows users to temporarily disable the gliding function by crouching. This is achieved through a new setting that checks the player's crouch status and stops the glide accordingly when this setting is active.

Changes

File Path Change Summary
.../wurstclient/hacks/GlideHack.java Added doSneakFall CheckboxSetting; updated onUpdate to include a crouch check to control gliding.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@Lamby777 Lamby777 mentioned this pull request Jan 3, 2024
Closed
coderabbitai[bot]
coderabbitai bot reviewed Jan 3, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a952344 and 1815374.
Files selected for processing (1)
  • src/main/java/net/wurstclient/hacks/GlideHack.java (3 hunks)
Additional comments: 3
src/main/java/net/wurstclient/hacks/GlideHack.java (3)

  • 22-34: The new CheckboxSetting doSneakFall is well-named and includes a descriptive tooltip, which is good for user understanding.

  • 52-55: The addition of the doSneakFall setting to the constructor is correct and follows the existing pattern of adding settings.

  • 75-76: The conditional check for doSneakFall in the onUpdate method is correctly implemented to return early if the player is sneaking.

@Lamby777
Copy link
Author

Lamby777 commented Jan 3, 2024

woah this bot is cool

@Alexander01998 Alexander01998 added type:enhancement New feature or request area:settings Improves the settings of existing features. category:movement labels Jan 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks.

Pull requests should be closed if:

  • They have been superseded by another pull request
  • They are out of scope or don't align with the project
  • They have become obsolete due to other changes
  • They have bugs or conflicts that won't be resolved

@Lamby777
Copy link
Author

Lamby777 commented Mar 5, 2024

still active, awaiting reviews

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks.

Pull requests should be closed if:

  • They have been superseded by another pull request
  • They are out of scope or don't align with the project
  • They have become obsolete due to other changes
  • They have bugs or conflicts that won't be resolved

@Alexander01998 Alexander01998 added status:never-stale Prevents stalebot from marking this item as stale. and removed status:stale labels May 6, 2024
@antihack3r
Copy link
Contributor

...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:settings Improves the settings of existing features. category:movement status:never-stale Prevents stalebot from marking this item as stale. type:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lamby777 @antihack3r @Alexander01998